Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve latest snapshot query #12

Merged
merged 20 commits into from
Oct 7, 2024
Merged

Conversation

hahn-kev
Copy link
Collaborator

when testing medium sized dbs adding changes was slow due to this one query, I've improved it, but I'm not happy with our performance tests, so I'll have to work on those a bit more

@hahn-kev hahn-kev marked this pull request as ready for review August 29, 2024 09:03
…nually and verify the performance as part of a test
…red with `ChangesToSnapshotsAreNotSaved`. Fixing that uncovered tests that depend on snapshots being tracked between test phases. Also fixed tests which were over-specifying the expected time when there was a mismatch in time offset that was acceptable.
…mplement the matching return type without restricting the collection type. Split `GetChanges` helper to `GetMissingCommits` which returns an IAsyncEnumerable, this allows the server to use less memory when responding to requests with a large number of commits
@hahn-kev hahn-kev requested a review from myieye September 20, 2024 07:11
@hahn-kev hahn-kev enabled auto-merge (squash) October 7, 2024 06:28
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No serious behavioural changes, so I think this looks good and I just have two little comments.

src/SIL.Harmony/DataModel.cs Show resolved Hide resolved
…its, lookup just the ids for entities changed
@hahn-kev hahn-kev merged commit 0340cd4 into main Oct 7, 2024
2 checks passed
@hahn-kev hahn-kev deleted the chore/11-improve-latest-snapshot-query branch October 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants